Skip to content

Built-In-Target-Docs#4689

Merged
ValGrimm-U3D merged 1 commit into
masterfrom
shadergraph/doc/builtintarget
Jun 4, 2021
Merged

Built-In-Target-Docs#4689
ValGrimm-U3D merged 1 commit into
masterfrom
shadergraph/doc/builtintarget

Conversation

@ValGrimm-U3D
Copy link
Copy Markdown
Contributor

Please read the Contributing guide before making a PR.

Checklist for PR maker

  • [ N/A] Have you added a backport label (if needed)? For example, the need-backport-* label. After you backport the PR, the label changes to backported-*.
  • [ N/A] Have you updated the changelog? Each package has a CHANGELOG.md file.
  • [N/A ] Have you updated or added the documentation for your PR? When you add a new feature, change a property name, or change the behavior of a feature, it's best practice to include related documentation changes in the same PR. If you do add documentation, make sure to add the relevant Graphics Docs team member as a reviewer of the PR. If you are not sure which person to add, see the Docs team contacts sheet.
  • [N/A ] Have you added a graphic test for your PR (if needed)? When you add a new feature, or discover a bug that tests don't cover, please add a graphic test.

Purpose of this PR

Why is this PR needed, what hard problem is it solving/fixing?


Testing status

Describe what manual/automated tests were performed for this PR


Comments to reviewers

Notes for the reviewers you have assigned.

@ValGrimm-U3D ValGrimm-U3D requested a review from a team as a code owner May 27, 2021 14:05
@ValGrimm-U3D ValGrimm-U3D requested a review from izzy-rees May 27, 2021 14:05
@ValGrimm-U3D ValGrimm-U3D changed the title changes to the 3 applicable files Built In Target Docs May 27, 2021
@github-actions
Copy link
Copy Markdown

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page)
and cancel any jobs that started on Yamato.
See the PR template for more information.
Thank you!

@ValGrimm-U3D ValGrimm-U3D changed the title Built In Target Docs Built-In-Target-Docs May 27, 2021
Copy link
Copy Markdown
Contributor

@jessebarker jessebarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like what we talked about. Thanks.

@ValGrimm-U3D ValGrimm-U3D merged commit 91ab7ad into master Jun 4, 2021
@ValGrimm-U3D ValGrimm-U3D deleted the shadergraph/doc/builtintarget branch June 4, 2021 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants